chenboat commented on a change in pull request #5639:
URL: https://github.com/apache/incubator-pinot/pull/5639#discussion_r448736274
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -355,10 +355,17 @@ void setIdealState(String realtimeTableName, IdealState
idealState) {
* This method moves the segment file from another location to its permanent
location.
* When splitCommit is enabled, segment file is uploaded to the
segmentLocation in the committingSegmentDescriptor,
* and we need to move the segment file to its permanent location before
committing the segment metadata.
+ * Updated the segment location to the uri which the segment is moved to.
+ * Exception: for committingSegmentDescriptor with peer download scheme in
its segment location, there is no need for
+ * moving.
Review comment:
DONE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
