mcvsubbu commented on a change in pull request #5718:
URL: https://github.com/apache/incubator-pinot/pull/5718#discussion_r463895616
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java
##########
@@ -485,4 +503,80 @@ private void deleteSegmentsInternal(String
tableNameWithType, List<String> segme
throw new ControllerApplicationException(LOGGER, e.getMessage(),
Response.Status.FORBIDDEN);
}
}
+
+ @GET
+ @Path("segments/{tableName}/reload-status")
+ @Produces(MediaType.APPLICATION_JSON)
+ @ApiOperation(value = "Status of segment reload", notes = "Status of segment
reload")
Review comment:
If you are adding one to get the status of one segment at a time, then
the user can (if needed) iterate over the segments and get each segment. Let us
evaluate the use case first. Are we talking about a full table reload or a
segment reload? If full table reload, maybe we only want to return those
segments that DID NOT reload properly?
The API definition leaves much discussion to be desired, and a PR is NOT the
place to discuss API. If you have a design doc, we will discuss there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
