guruguha commented on a change in pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#discussion_r475101707
########## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentStatus.java ########## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.restlet.resources; + +import java.util.Objects; + +public class SegmentStatus { Review comment: I think we do have that separation. We have a class `TableReloadStatus` in the controller that can be used to enhance any future requirements. The `SegmentLoadStatus` class can be then used for specific API - the loadStatus API. I have added JSON ignore to the `SegmentLoadStatus` class. ########## File path: pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/SegmentStatus.java ########## @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.restlet.resources; + +/** + * Holds segment last reload time status along with any errors for a segment with unsuccessful call to get reload times. + * + * NOTE: This class is being used in both the controller and the server. There is tight coupling between them. + * So, the API contract cannot be changed without changing or refactoring this class. + * + * TODO: refactor this class to be handled better. Make sure to have an extensible design that helps add more + */ +public class SegmentStatus { + // Name of the segment itself + public String _segmentName; + // The last segment reload time in ISO date format (yyyy-MM-dd HH:mm:ss:SSS UTC) + // If the segment reload failed for a segment, then the value will be the previous segment reload was successful + public String _segmentReloadTimeUTC; Review comment: The date is in string format: ISO date format (yyyy-MM-dd HH:mm:ss:SSS UTC) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
