kishoreg commented on a change in pull request #5853:
URL: https://github.com/apache/incubator-pinot/pull/5853#discussion_r470414920
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/invertedindex/RangeIndexHandler.java
##########
@@ -140,17 +145,64 @@ private void handleDictionaryBasedColumn(ColumnMetadata
columnMetadata)
}
}
+ private void handleNonDictionaryBasedColumn(ColumnMetadata columnMetadata)
+ throws IOException {
+ int numDocs = columnMetadata.getTotalDocs();
+ try (RangeIndexCreator creator = new RangeIndexCreator(_indexDir,
columnMetadata.getFieldSpec(),
+ FieldSpec.DataType.INT, -1, -1, numDocs,
columnMetadata.getTotalNumberOfEntries())) {
+ try (ForwardIndexReader forwardIndexReader =
getForwardIndexReader(columnMetadata, _segmentWriter);
+ ForwardIndexReaderContext readerContext =
forwardIndexReader.createContext()) {
+ if (columnMetadata.isSingleValue()) {
+ // Single-value column.
+ for (int i = 0; i < numDocs; i++) {
+ switch (columnMetadata.getDataType()) {
Review comment:
move the switch outside of for loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
