KKcorps commented on a change in pull request #5853:
URL: https://github.com/apache/incubator-pinot/pull/5853#discussion_r477295223
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
##########
@@ -165,26 +166,63 @@ public RangeIndexCreator(File indexDir, FieldSpec
fieldSpec, FieldSpec.DataType
}
@Override
- public void add(int dictId) {
- _numberValueBuffer.put(_nextDocId, dictId);
- _docIdBuffer.put(_nextDocId, _nextDocId);
- _nextDocId = _nextDocId + 1;
+ public void add(int value) {
+ addValueToBuffer(value);
+ nextDoc();
}
@Override
- public void add(int[] dictIds, int length) {
+ public void add(int[] values, int length) {
for (int i = 0; i < length; i++) {
- int dictId = dictIds[i];
- _numberValueBuffer.put(_nextValueId, dictId);
- _docIdBuffer.put(_nextValueId, _nextDocId);
- _nextValueId = _nextValueId + 1;
+ addValueToBuffer(values[i]);
+ nextDoc();
Review comment:
done
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/RangeIndexCreator.java
##########
@@ -165,26 +166,63 @@ public RangeIndexCreator(File indexDir, FieldSpec
fieldSpec, FieldSpec.DataType
}
@Override
- public void add(int dictId) {
- _numberValueBuffer.put(_nextDocId, dictId);
- _docIdBuffer.put(_nextDocId, _nextDocId);
- _nextDocId = _nextDocId + 1;
+ public void add(int value) {
+ addValueToBuffer(value);
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
