KKcorps commented on a change in pull request #5853:
URL: https://github.com/apache/incubator-pinot/pull/5853#discussion_r477295356
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/index/loader/invertedindex/RangeIndexHandler.java
##########
@@ -140,17 +145,70 @@ private void handleDictionaryBasedColumn(ColumnMetadata
columnMetadata)
}
}
+ private void handleNonDictionaryBasedColumn(ColumnMetadata columnMetadata)
+ throws IOException {
+ int numDocs = columnMetadata.getTotalDocs();
+ try (RangeIndexCreator creator = new RangeIndexCreator(_indexDir,
columnMetadata.getFieldSpec(),
+ columnMetadata.getDataType(), -1, -1, numDocs,
columnMetadata.getTotalNumberOfEntries())) {
+ try (ForwardIndexReader forwardIndexReader =
getForwardIndexReader(columnMetadata, _segmentWriter);
+ ForwardIndexReaderContext readerContext =
forwardIndexReader.createContext()) {
+ if (columnMetadata.isSingleValue()) {
+ // Single-value column.
+ switch (columnMetadata.getDataType()) {
+ case INT: {
+ for (int i = 0; i < numDocs; i++) {
+ creator.add(forwardIndexReader.getInt(i, readerContext));
+ }
+ break;
+ }
+ case LONG: {
+ for (int i = 0; i < numDocs; i++) {
+ creator.add(forwardIndexReader.getLong(i, readerContext));
+ }
+ break;
+ }
+ case FLOAT: {
+ for (int i = 0; i < numDocs; i++) {
+ creator.add(forwardIndexReader.getFloat(i, readerContext));
+ }
+ break;
+ }
+ case DOUBLE: {
+ for (int i = 0; i < numDocs; i++) {
+ creator.add(forwardIndexReader.getDouble(i, readerContext));
+ }
+ break;
+ }
+ default: {
+ throw new RuntimeException("Range indexing is not supported");
+ }
+ }
+ }
+ creator.seal();
+ }
+ }
+ }
+
private ForwardIndexReader<?> getForwardIndexReader(ColumnMetadata
columnMetadata,
SegmentDirectory.Writer segmentWriter)
throws IOException {
PinotDataBuffer buffer =
segmentWriter.getIndexFor(columnMetadata.getColumnName(),
ColumnIndexType.FORWARD_INDEX);
int numRows = columnMetadata.getTotalDocs();
int numBitsPerValue = columnMetadata.getBitsPerElement();
if (columnMetadata.isSingleValue()) {
- return new FixedBitSVForwardIndexReader(buffer, numRows,
numBitsPerValue);
+ if (columnMetadata.hasDictionary()) {
+ return new FixedBitSVForwardIndexReader(buffer, numRows,
numBitsPerValue);
+ } else {
+ return new FixedByteChunkSVForwardIndexReader(buffer,
columnMetadata.getDataType());
+ }
} else {
- return new FixedBitMVForwardIndexReader(buffer, numRows,
columnMetadata.getTotalNumberOfEntries(),
- numBitsPerValue);
+ if (columnMetadata.hasDictionary()) {
+ return new FixedBitMVForwardIndexReader(buffer, numRows,
columnMetadata.getTotalNumberOfEntries(),
+ numBitsPerValue);
+ } else {
+ throw new RuntimeException("Range indexing is not supported for multi
value non-dictionary columns");
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
