snleee commented on pull request #6066: URL: https://github.com/apache/incubator-pinot/pull/6066#issuecomment-700245091
> > why do we want a flag for this? can we enable this by default when there is a schema. Let's avoid adding feature flags if possible. > > The concern is that it may fail some existing use cases, which could cause production impact. And the silent 0 response has been supported for quite a while. > I also thought about making it as a broker level config, while the broker could be shared by multiple tables, which expected behaviors might be different. > That's why I make it as a flag in the query options. IMO, we should set this as the default behavior for SQL endpoint. For PQL, we can keep the backward compatibility since it has been on production for a while. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
