kishoreg commented on pull request #6066: URL: https://github.com/apache/incubator-pinot/pull/6066#issuecomment-700310284
> The concern is that it may fail some existing use cases, which could cause production impact. And the silent 0 response has been supported for quite a while. > I also thought about making it as a broker level config, while the broker could be shared by multiple tables, which expected behaviors might be different. > That's why I make it as a flag in the query options. I don't get this. if its already returning 0 results what are we trying to achieve by adding this behavior? Are users going to change their query to validate it. If they are already changing the code, isn't it better for them to change the way they handle the error. overall, we should try to get this feature without adding a config flag. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
