noahprince22 commented on a change in pull request #6250:
URL: https://github.com/apache/incubator-pinot/pull/6250#discussion_r520926554



##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/ImmutableSegmentDataManager.java
##########
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.pinot.core.data.manager.offline;
+package org.apache.pinot.core.data.manager.realtime;

Review comment:
       `ImmutableSegmentDataManager` is not used inside of offline anymore. 
Only realtime. So I think it makes sense to be under this package. Certainly 
doesn't make sense to have it under `offline` anymore. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to