mcvsubbu commented on a change in pull request #6250:
URL: https://github.com/apache/incubator-pinot/pull/6250#discussion_r520936823
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -379,6 +382,16 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
return new
BrokerResponseNative(QueryException.getException(QueryException.BROKER_TIMEOUT_ERROR,
errorMessage));
}
+ // Validate the request
+ try {
+ validateNumSegments(offlineRoutingTable, realtimeRoutingTable,
_querySegmentLimit);
Review comment:
Maybe I am missing the context, but are you trying to avoid cut-off
because the queries become slower? If so, a better way is to honor the max time
limit (which, I believe, is now being passed to the server via PinotQuery
request). Is this a part of lazy load, or does this belong in a different PR?
If it is a part of lazy load, can you share some information of how this is
related? You can do it in the design doc. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
