noahprince22 commented on a change in pull request #6250:
URL: https://github.com/apache/incubator-pinot/pull/6250#discussion_r524352481
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -379,6 +382,16 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
return new
BrokerResponseNative(QueryException.getException(QueryException.BROKER_TIMEOUT_ERROR,
errorMessage));
}
+ // Validate the request
+ try {
+ validateNumSegments(offlineRoutingTable, realtimeRoutingTable,
_querySegmentLimit);
Review comment:
This is part of lazy loading. It's a guard to keep you from causing tons
of segments to be pulled from the deep store to a local disc that may not have
very much space, since it's meant more for random access of a few segments; not
pulling a whole table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
