siddharthteotia commented on a change in pull request #6728:
URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r604761829
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -439,27 +440,55 @@ public String toString(Object value) {
SHORT_ARRAY,
+ PRIMITIVE_INT_ARRAY {
Review comment:
Do we need to have both INTEGER_ARRAY and PRIMITIVE_INT_ARRAY ?
We can just use the latter right?
Secondly, INT or INTEGER is a primitive type (at least logically). None of
them is a complex type. But looks like we are differentiating between both for
multi-value columns? In that case what about INT (PRIMITIVE_INT) v/s INTEGER
for single valued columns ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
