siddharthteotia edited a comment on pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#issuecomment-810954992
High level question - can we consider merging these different specifications of data types. The DataType captured in the schema has both SV and MV for primitives so why can't we use that all the way even in functions. Also, not necessarily related to this PR but I don't think I fully understand the purpose of PinotDataType. It is currently used in record transformer and functions. For functions only in scalar transform functions and ingest transform functions for type conversion. Why do we need to convert the types between parameter type and argument type? For example, if we have foo (long 123), then parameterType is long and argument type is int ? Why do we need to convert ? The only place where we should convert is for cast functions but there we don't even use PinotDataType I feel a lot of type related code in FunctionInvoker and FunctionUtils can be cleaned up if we have a unified type throughout the engine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
