Jackie-Jiang commented on a change in pull request #7246:
URL: https://github.com/apache/pinot/pull/7246#discussion_r684399169
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/PrimaryKey.java
##########
@@ -35,6 +36,10 @@ public PrimaryKey(Object[] values) {
return _values;
}
+ public byte[] asBytes() {
+ return SerializationUtils.serialize(_values);
Review comment:
Primary key might contain `ByteArray` which is not `Serializable`.
Can we check the byte size for the java ser/de result? My impression is that
it will be quite large. This will be a very frequent operation for upsert (per
record), so want to make sure it is efficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
