Jackie-Jiang commented on a change in pull request #7246:
URL: https://github.com/apache/pinot/pull/7246#discussion_r684848620
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java
##########
@@ -40,9 +40,16 @@
APPEND, INCREMENT, OVERWRITE, UNION
}
+ public enum HashFunction {
+ NONE, MD5, MURMUR3
Review comment:
That one I also suggested using `null` in the code review... Having an
upsert config with `NONE` mode which disables it doesn't seems very clean to
me. But I'm okay if you strongly feel this way is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
