yupeng9 commented on a change in pull request #7246:
URL: https://github.com/apache/pinot/pull/7246#discussion_r684546247
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/PrimaryKey.java
##########
@@ -35,6 +36,10 @@ public PrimaryKey(Object[] values) {
return _values;
}
+ public byte[] asBytes() {
+ return SerializationUtils.serialize(_values);
Review comment:
you are right. i need to mark ByteArray as serializable. Any other types
that we need to consider?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
