yupeng9 commented on a change in pull request #7246:
URL: https://github.com/apache/pinot/pull/7246#discussion_r685337907
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java
##########
@@ -239,11 +238,12 @@ public void removeSegment(IndexSegment segment) {
}
public static final class RecordInfo {
- private final PrimaryKey _primaryKey;
+ /** stores the primary key of the record or its hash value */
+ private final Object _primaryKey;
private final int _docId;
private final Comparable _comparisonValue;
- public RecordInfo(PrimaryKey primaryKey, int docId, Comparable
comparisonValue) {
+ public RecordInfo(Object primaryKey, int docId, Comparable
comparisonValue) {
Review comment:
hmm, to check we are speaking about the same thing.
do you mean
```
class RecordInfo {
private final Object _primaryKey;
private final int _docId;
private final Comparable _comparisonValue;
private final HashFunction _function;
```
by carrying additional field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
