Jackie-Jiang commented on a change in pull request #7255:
URL: https://github.com/apache/pinot/pull/7255#discussion_r685382782
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java
##########
@@ -144,34 +141,25 @@ public static void
removeResourceConfigFromPropertyStore(ZkHelixPropertyStore<ZN
}
}
- public static boolean
setOfflineSegmentZKMetadata(ZkHelixPropertyStore<ZNRecord> propertyStore,
- String offlineTableName, OfflineSegmentZKMetadata
offlineSegmentZKMetadata, int expectedVersion) {
+ public static boolean setSegmentZKMetadata(ZkHelixPropertyStore<ZNRecord>
propertyStore, String tableNameWithType,
+ SegmentZKMetadata segmentZKMetadata, int expectedVersion) {
// NOTE: Helix will throw ZkBadVersionException if version does not match
try {
return propertyStore
- .set(constructPropertyStorePathForSegment(offlineTableName,
offlineSegmentZKMetadata.getSegmentName()),
- offlineSegmentZKMetadata.toZNRecord(), expectedVersion,
AccessOption.PERSISTENT);
+ .set(constructPropertyStorePathForSegment(tableNameWithType,
segmentZKMetadata.getSegmentName()),
+ segmentZKMetadata.toZNRecord(), expectedVersion,
AccessOption.PERSISTENT);
} catch (ZkBadVersionException e) {
return false;
}
}
- public static boolean
setOfflineSegmentZKMetadata(ZkHelixPropertyStore<ZNRecord> propertyStore,
- String offlineTableName, OfflineSegmentZKMetadata
offlineSegmentZKMetadata) {
- return propertyStore
- .set(constructPropertyStorePathForSegment(offlineTableName,
offlineSegmentZKMetadata.getSegmentName()),
- offlineSegmentZKMetadata.toZNRecord(), AccessOption.PERSISTENT);
- }
-
- public static boolean
setRealtimeSegmentZKMetadata(ZkHelixPropertyStore<ZNRecord> propertyStore,
- String realtimeTableName, RealtimeSegmentZKMetadata
realtimeSegmentZKMetadata) {
- return propertyStore
- .set(constructPropertyStorePathForSegment(realtimeTableName,
realtimeSegmentZKMetadata.getSegmentName()),
- realtimeSegmentZKMetadata.toZNRecord(), AccessOption.PERSISTENT);
+ public static boolean setSegmentZKMetadata(ZkHelixPropertyStore<ZNRecord>
propertyStore, String tableNameWithType,
+ SegmentZKMetadata segmentZKMetadata) {
+ return setSegmentZKMetadata(propertyStore, tableNameWithType,
segmentZKMetadata, -1);
}
@Nullable
- public static ZNRecord getZnRecord(@Nonnull ZkHelixPropertyStore<ZNRecord>
propertyStore, @Nonnull String path) {
+ public static ZNRecord getZnRecord(ZkHelixPropertyStore<ZNRecord>
propertyStore, String path) {
Review comment:
`Nonnull` and `Nullable` looks quite similar, so we usually only keep
`Nullable` and assume the variables are `Nonnull` by default (google convention)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
