Jackie-Jiang commented on a change in pull request #7255:
URL: https://github.com/apache/pinot/pull/7255#discussion_r686340364
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/validation/RealtimeSegmentValidationManager.java
##########
@@ -136,14 +135,14 @@ static long
computeRealtimeTotalDocumentInSegments(List<RealtimeSegmentZKMetadat
groupId = segmentGroupIdName;
}
// Discard all segments with different groupids as they are replicas
- if (groupId.equals(segmentGroupIdName) &&
realtimeSegmentZKMetadata.getTotalDocs() >= 0) {
- numTotalDocs += realtimeSegmentZKMetadata.getTotalDocs();
+ if (groupId.equals(segmentGroupIdName) &&
segmentZKMetadata.getTotalDocs() >= 0) {
+ numTotalDocs += segmentZKMetadata.getTotalDocs();
}
}
} else {
Review comment:
I think it is needed during the migration from HLC to LLC. Also, out of
the scope of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
