Jackie-Jiang commented on a change in pull request #7255:
URL: https://github.com/apache/pinot/pull/7255#discussion_r686337781
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotRealtimeSegmentManager.java
##########
@@ -201,15 +201,13 @@ private synchronized void
assignRealtimeSegmentsToServerInstancesIfNecessary() {
for (String partition : state.getPartitionSet()) {
// Helix partition is the segment name
if (SegmentName.isHighLevelConsumerSegmentName(partition)) {
- HLCSegmentName segName = new HLCSegmentName(partition);
- RealtimeSegmentZKMetadata realtimeSegmentZKMetadata =
ZKMetadataProvider
-
.getRealtimeSegmentZKMetadata(_pinotHelixResourceManager.getPropertyStore(),
segName.getTableName(),
- partition);
- if (realtimeSegmentZKMetadata == null) {
+ SegmentZKMetadata segmentZKMetadata = ZKMetadataProvider
Review comment:
partition is the same as segment name (mentioned in the comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
