yupeng9 commented on a change in pull request #7269:
URL: https://github.com/apache/pinot/pull/7269#discussion_r686362226
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
##########
@@ -77,6 +79,14 @@ public void setTimeType(String timeType) {
_timeType = TimeUtils.timeUnitFromString(timeType);
}
+ public boolean isNullTimeColumnHandlingEnabled() {
+ return _nullTimeColumnHandlingEnabled;
+ }
+
+ public void setNullTimeColumnHandlingEnabled(boolean
nullTimeColumnHandlingEnabled) {
Review comment:
add the release notes about this new config?
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/NullValueTransformer.java
##########
@@ -52,6 +64,12 @@ public GenericRow transform(GenericRow record) {
record.putDefaultNullValue(fieldName, entry.getValue());
}
}
+
+ // handle null value in time column
+ if (_timeConverter != null && record.getValue(_timeColumnName) == null) {
+ record.putDefaultNullValue(_timeColumnName,
_timeConverter.fromMillisSinceEpoch(System.currentTimeMillis()));
Review comment:
+1. plz add a test for different time granularity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
