Jackie-Jiang commented on a change in pull request #7269:
URL: https://github.com/apache/pinot/pull/7269#discussion_r688822369
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/NullValueTransformer.java
##########
@@ -41,6 +47,14 @@ public NullValueTransformer(Schema schema) {
}
}
}
+
+ if (tableConfig.getValidationConfig().isAllowNullTimeValue() &&
timeColumnName != null && schema.getSpecForTimeColumn(timeColumnName) != null) {
Review comment:
`schema.getSpecForTimeColumn(timeColumnName)` can be expensive because
it might need to convert the field type, let's only call it once. We can assert
that it is not null because if time column is defined, it must be configured
within the schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
