liuchang0520 commented on a change in pull request #7269:
URL: https://github.com/apache/pinot/pull/7269#discussion_r687035193
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/NullValueTransformer.java
##########
@@ -20,16 +20,20 @@
import java.util.HashMap;
import java.util.Map;
+import org.apache.pinot.spi.config.table.TableConfig;
import org.apache.pinot.spi.data.FieldSpec;
import org.apache.pinot.spi.data.FieldSpec.FieldType;
import org.apache.pinot.spi.data.Schema;
import org.apache.pinot.spi.data.readers.GenericRow;
+import org.apache.pinot.spi.utils.TimeConverter;
public class NullValueTransformer implements RecordTransformer {
private final Map<String, Object> _defaultNullValues = new HashMap<>();
+ private final TimeConverter _timeConverter;
+ private final String _timeColumnName;
- public NullValueTransformer(Schema schema) {
+ public NullValueTransformer(TableConfig tableConfig, Schema schema) {
for (FieldSpec fieldSpec : schema.getAllFieldSpecs()) {
if (!fieldSpec.isVirtualColumn() && fieldSpec.getFieldType() !=
FieldType.TIME) {
Review comment:
Looks like the existing logic will only leave out `TIME `type as null.
`DATE_TIME` will be filled with default value by
`org.apache.pinot.spi.data.FieldSpec.getDefaultNullValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
