Jackie-Jiang commented on a change in pull request #7255:
URL: https://github.com/apache/pinot/pull/7255#discussion_r688102332
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1742,37 +1736,36 @@ public ZNRecord getSegmentMetadataZnRecord(String
tableNameWithType, String segm
ZKMetadataProvider.constructPropertyStorePathForSegment(tableNameWithType,
segmentName));
}
- public boolean updateZkMetadata(String offlineTableName,
OfflineSegmentZKMetadata segmentMetadata,
- int expectedVersion) {
+ public boolean updateZkMetadata(String tableNameWithType, SegmentZKMetadata
segmentZKMetadata, int expectedVersion) {
return ZKMetadataProvider
- .setOfflineSegmentZKMetadata(_propertyStore, offlineTableName,
segmentMetadata, expectedVersion);
+ .setSegmentZKMetadata(_propertyStore, tableNameWithType,
segmentZKMetadata, expectedVersion);
}
- public boolean updateZkMetadata(String offlineTableName,
OfflineSegmentZKMetadata segmentMetadata) {
- return ZKMetadataProvider.setOfflineSegmentZKMetadata(_propertyStore,
offlineTableName, segmentMetadata);
+ public boolean updateZkMetadata(String tableNameWithType, SegmentZKMetadata
segmentZKMetadata) {
+ return ZKMetadataProvider.setSegmentZKMetadata(_propertyStore,
tableNameWithType, segmentZKMetadata);
}
- public void refreshSegment(String offlineTableName, SegmentMetadata
segmentMetadata,
- OfflineSegmentZKMetadata offlineSegmentZKMetadata, String downloadUrl,
@Nullable String crypter) {
+ public void refreshSegment(String tableNameWithType, SegmentMetadata
segmentMetadata,
+ SegmentZKMetadata segmentZKMetadata, String downloadUrl, @Nullable
String crypter) {
String segmentName = segmentMetadata.getName();
// NOTE: Must first set the segment ZK metadata before trying to refresh
because servers and brokers rely on segment
// ZK metadata to refresh the segment (server will compare the segment ZK
metadata with the local metadata to decide
// whether to download the new segment; broker will update the the segment
partition info & time boundary based on
// the segment ZK metadata)
ZKMetadataUtils
- .updateSegmentMetadata(offlineSegmentZKMetadata, segmentMetadata,
CommonConstants.Segment.SegmentType.OFFLINE);
- offlineSegmentZKMetadata.setRefreshTime(System.currentTimeMillis());
- offlineSegmentZKMetadata.setDownloadUrl(downloadUrl);
- offlineSegmentZKMetadata.setCrypterName(crypter);
- if (!ZKMetadataProvider.setOfflineSegmentZKMetadata(_propertyStore,
offlineTableName, offlineSegmentZKMetadata)) {
+ .updateSegmentMetadata(segmentZKMetadata, segmentMetadata,
CommonConstants.Segment.SegmentType.OFFLINE);
Review comment:
For now, yes. When we remove the segment type completely after releasing
`0.9.0`, we can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
