klsince commented on a change in pull request #7969:
URL: https://github.com/apache/pinot/pull/7969#discussion_r784359166
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java
##########
@@ -371,9 +360,9 @@ public void addOrReplaceSegment(String segmentName,
IndexLoadingConfig indexLoad
// Download segment and replace the local one, either due to failure to
recover local segment,
// or the segment data is updated and has new CRC now.
if (localMetadata == null) {
- LOGGER.info("Download segment: {} of table: {} as no good one exists
locally", segmentName, _tableNameWithType);
+ LOGGER.info("Download segment: {} of table: {} as it doesn't exist",
segmentName, _tableNameWithType);
} else {
- LOGGER.info("Download segment: {} of table: {} as local crc: {}
mismatches remote crc: {}.", segmentName,
+ LOGGER.info("Download segment: {} of table: {} as crc changes from: {}
to: {}", segmentName,
Review comment:
This is a good question. Either of them gets logged in one method call,
but not both. Because the two CRC checks have used CRC values from different
places when comparing with the CRC in SegmentZKMetadata.
Here the `localMetadata` object is not null, and the CRC from it has been
used to compare with the CRC in SegmentZkMetadata (L342). The
tryLoadExistingSegment() method is called when `localMetadata` is null. And the
CRC is retrieved from segment potentially exists locally (but not loaded yet)
to compare with the CRC in SegmentZkMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
