mcvsubbu commented on a change in pull request #7969:
URL: https://github.com/apache/pinot/pull/7969#discussion_r784425679
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java
##########
@@ -484,6 +484,13 @@ private void removeBackup(File indexDir)
FileUtils.deleteDirectory(segmentTempDir);
}
+ /**
+ * Try to load the segment potentially still existing on the server.
+ *
+ * @return true if the segment still exists on server, its CRC is still same
with the
+ * one in SegmentZKMetadata and is loaded into memory successfully; false if
it doesn't
+ * exist on the server, its CRC has changed, or it fails to be loaded.
Review comment:
please add the segmentdirectory is closed when it is false, open
otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
