Jackie-Jiang commented on a change in pull request #8296:
URL: https://github.com/apache/pinot/pull/8296#discussion_r819975052
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##########
@@ -303,11 +302,11 @@ public synchronized void buildRouting(String
tableNameWithType) {
TableConfig tableConfig =
ZKMetadataProvider.getTableConfig(_propertyStore, tableNameWithType);
Preconditions.checkState(tableConfig != null, "Failed to find table config
for table: %s", tableNameWithType);
- IdealState idealState = getIdealState(tableNameWithType);
+ IdealState idealState =
getIdealState(getIdealStatePath(tableNameWithType));
Review comment:
Shall we cache the `idealStatePath` and `externalViewPath` so that they
can be reused to create the `RoutingEntry`?
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##########
@@ -516,11 +526,14 @@ public Long getQueryTimeoutMs(String tableNameWithType) {
// Time boundary manager is only available for the offline part of the
hybrid table
transient TimeBoundaryManager _timeBoundaryManager;
- RoutingEntry(String tableNameWithType, SegmentPreSelector
segmentPreSelector, SegmentSelector segmentSelector,
- List<SegmentPruner> segmentPruners, InstanceSelector instanceSelector,
int lastUpdateIdealStateVersion,
- int lastUpdateExternalViewVersion, @Nullable TimeBoundaryManager
timeBoundaryManager,
+ RoutingEntry(String tableNameWithType, String externalViewPath, String
idealStatePath,
Review comment:
(minor) Shall we put `idealStatePath` in front of `externalViewPath` to
be consistent with the order of `lastUpdateVersion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
