Jackie-Jiang commented on a change in pull request #8296:
URL: https://github.com/apache/pinot/pull/8296#discussion_r819995034
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##########
@@ -303,11 +302,11 @@ public synchronized void buildRouting(String
tableNameWithType) {
TableConfig tableConfig =
ZKMetadataProvider.getTableConfig(_propertyStore, tableNameWithType);
Preconditions.checkState(tableConfig != null, "Failed to find table config
for table: %s", tableNameWithType);
- IdealState idealState = getIdealState(tableNameWithType);
+ IdealState idealState =
getIdealState(getIdealStatePath(tableNameWithType));
Review comment:
What I meant is to put it in a local variable, and reuse it in line 382
when creating the `RoutingEntry`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
