richardstartin commented on a change in pull request #8296:
URL: https://github.com/apache/pinot/pull/8296#discussion_r819978353
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/RoutingManager.java
##########
@@ -303,11 +302,11 @@ public synchronized void buildRouting(String
tableNameWithType) {
TableConfig tableConfig =
ZKMetadataProvider.getTableConfig(_propertyStore, tableNameWithType);
Preconditions.checkState(tableConfig != null, "Failed to find table config
for table: %s", tableNameWithType);
- IdealState idealState = getIdealState(tableNameWithType);
+ IdealState idealState =
getIdealState(getIdealStatePath(tableNameWithType));
Review comment:
I don't think that's wise because this is called by an external API and
could be used to OOM the server, unless you have an eviction policy, at which
point this is getting far too complicated. The purpose of this change is just
to reduce allocation when the broker is ideal and just handling cluster updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
