walterddr commented on code in PR #8648:
URL: https://github.com/apache/pinot/pull/8648#discussion_r866870529
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -277,6 +277,10 @@ public ColumnDataType getStoredType() {
return LONG;
case JSON:
return STRING;
+ case BOOLEAN_ARRAY:
Review Comment:
BigDecimal seems to be stored as is in its binary format. unless I am
mistaken @Jackie-Jiang
##########
pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java:
##########
@@ -417,10 +424,26 @@ private void fillDataTableWithRandomData(DataTableBuilder
dataTableBuilder,
DOUBLES[rowId] = RANDOM.nextDouble();
dataTableBuilder.setColumn(colId, DOUBLES[rowId]);
break;
+ case BIG_DECIMAL:
+ BIG_DECIMALS[rowId] = BigDecimal.valueOf(RANDOM.nextInt());
Review Comment:
BigDecimal has virtually no limit. However `RANDOM.nextDouble()`.
the goal here is not to test the arithmetic of BigDecimal but rather the
variable length ser/de, so I think double should cover a good variety. thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
