walterddr commented on code in PR #8648:
URL: https://github.com/apache/pinot/pull/8648#discussion_r866991463
##########
pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java:
##########
@@ -417,10 +424,26 @@ private void fillDataTableWithRandomData(DataTableBuilder
dataTableBuilder,
DOUBLES[rowId] = RANDOM.nextDouble();
dataTableBuilder.setColumn(colId, DOUBLES[rowId]);
break;
+ case BIG_DECIMAL:
+ BIG_DECIMALS[rowId] = BigDecimal.valueOf(RANDOM.nextInt());
Review Comment:
yes. according to the class def:
- BigDecimal = BigInteger + scale
- BigInteger = bitCount + bitLength + firstNonzeroIntNum + lowestSetBit +
signum + int[] mag (4+4+4+4+4+int[])
i think the mag should be dynamic enough (e.g. for using double as random
input)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
