nizarhejazi commented on code in PR #8742:
URL: https://github.com/apache/pinot/pull/8742#discussion_r878496125
##########
pinot-core/src/main/java/org/apache/pinot/core/data/table/TableResizer.java:
##########
@@ -79,14 +79,30 @@ public TableResizer(DataSchema dataSchema, QueryContext
queryContext) {
_numOrderByExpressions = orderByExpressions.size();
_orderByValueExtractors = new
OrderByValueExtractor[_numOrderByExpressions];
Comparator[] comparators = new Comparator[_numOrderByExpressions];
+ int[] comparisonSign = new int[_numGroupByExpressions];
Review Comment:
Found that in Presto: "The default null ordering is NULLS LAST, **regardless
of the ordering direction**". Will update the behviour in Pinot to match it.
##########
pinot-core/src/main/java/org/apache/pinot/core/data/table/TableResizer.java:
##########
@@ -79,14 +79,30 @@ public TableResizer(DataSchema dataSchema, QueryContext
queryContext) {
_numOrderByExpressions = orderByExpressions.size();
_orderByValueExtractors = new
OrderByValueExtractor[_numOrderByExpressions];
Comparator[] comparators = new Comparator[_numOrderByExpressions];
+ int[] comparisonSign = new int[_numGroupByExpressions];
Review Comment:
Found that in Presto: "The default null ordering is NULLS LAST, **regardless
of the ordering direction**". Will update the behviour in Pinot to match it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
