nizarhejazi commented on code in PR #8742:
URL: https://github.com/apache/pinot/pull/8742#discussion_r879533091
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/stats/BigDecimalColumnPreIndexStatsCollector.java:
##########
@@ -112,8 +113,13 @@ public int getCardinality() {
}
@Override
- public boolean hasNull() {
- return false;
+ public boolean hasNulls() {
Review Comment:
Attempted to serialized whether dictionary has null value but found that
dictionary serialization format cannot be changed easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
