nizarhejazi commented on code in PR #8742:
URL: https://github.com/apache/pinot/pull/8742#discussion_r879535279
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java:
##########
@@ -173,6 +188,25 @@ public byte[] toBytes()
dataOutputStream.writeInt(bytes.length);
dataOutputStream.write(bytes);
}
+
+ // Write colum field specs.
+ // todo: consider serializing only defaultNullValues since this is the
only required info.
+ int fieldSpecsSize = _columnFieldSpecs == null ? 0 :
_columnFieldSpecs.length;
+ dataOutputStream.writeInt(fieldSpecsSize);
Review Comment:
Will take care of ensuring backward compatibility in final PR .. this is
just a draft PR to get the discussion going.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
