Jackie-Jiang commented on code in PR #8787:
URL: https://github.com/apache/pinot/pull/8787#discussion_r885891546
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##########
@@ -159,23 +159,23 @@ private KinesisRecordsBatch
getResult(StreamPartitionMsgOffset startOffset, Stre
return new KinesisRecordsBatch(recordList,
startShardToSequenceNum.getKey(), isEndOfShard);
} catch (IllegalStateException e) {
- LOGGER.warn("Illegal state exception, connection is broken", e);
+ LOGGER.debug("Illegal state exception, connection is broken: {}",
e.getMessage());
Review Comment:
I don't think this is what @navina means. IIUC, she was suggesting to log
warning for the message only, and log stack trace at debug level.
Side question, do we encounter these exceptions frequently? What is the side
effect when such exceptions are hit? Should we consider emitting some metrics
for better monitoring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
