KKcorps commented on code in PR #8787:
URL: https://github.com/apache/pinot/pull/8787#discussion_r887608914
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##########
@@ -159,23 +159,23 @@ private KinesisRecordsBatch
getResult(StreamPartitionMsgOffset startOffset, Stre
return new KinesisRecordsBatch(recordList,
startShardToSequenceNum.getKey(), isEndOfShard);
} catch (IllegalStateException e) {
- LOGGER.warn("Illegal state exception, connection is broken", e);
+ debugAndLogWarning("Illegal state exception, connection is broken", e);
return handleException(kinesisStartCheckpoint, recordList);
} catch (ProvisionedThroughputExceededException e) {
- LOGGER.warn("The request rate for the stream is too high", e);
+ debugAndLogWarning("The request rate for the stream is too high", e);
return handleException(kinesisStartCheckpoint, recordList);
} catch (ExpiredIteratorException e) {
- LOGGER.warn("ShardIterator expired while trying to fetch records", e);
+ debugAndLogWarning("ShardIterator expired while trying to fetch
records", e);
return handleException(kinesisStartCheckpoint, recordList);
} catch (ResourceNotFoundException | InvalidArgumentException e) {
// aws errors
- LOGGER.error("Encountered AWS error while attempting to fetch records",
e);
+ LOGGER.error("Encountered AWS error while attempting to fetch records:
{}", e.getMessage());
Review Comment:
This error requires some user intervention most of the time. It is either
due to wrong credentials, no streams existing with the name, in correct region
or something else. Which is why it is logged as error and not a warning. Since
it was an error log, I just kept the stacktrace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
