KKcorps commented on code in PR #8787:
URL: https://github.com/apache/pinot/pull/8787#discussion_r886354409
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##########
@@ -159,23 +159,23 @@ private KinesisRecordsBatch
getResult(StreamPartitionMsgOffset startOffset, Stre
return new KinesisRecordsBatch(recordList,
startShardToSequenceNum.getKey(), isEndOfShard);
} catch (IllegalStateException e) {
- LOGGER.warn("Illegal state exception, connection is broken", e);
+ LOGGER.debug("Illegal state exception, connection is broken: {}",
e.getMessage());
Review Comment:
Ok. Yeah that makes sense. And yes some of these can occur frequently e.g.
ProvisionedThroughputExceeded or InterruptedException because of timeouts. We
just return whatever records we have back to the fetcher. We do log errors in
the case when we cannot find the stream itself in AWS or some Exception
occurred which is not expected in Kinesis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
