Jackie-Jiang commented on code in PR #8708:
URL: https://github.com/apache/pinot/pull/8708#discussion_r886121748
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -505,34 +505,40 @@ static void validateTaskConfigs(TableConfig tableConfig,
Schema schema) {
* - comparison column exists
*/
@VisibleForTesting
- static void validateUpsertConfig(TableConfig tableConfig, Schema schema) {
- if (tableConfig.getUpsertMode() == UpsertConfig.Mode.NONE) {
+ static void validateUpsertAndDedupConfig(TableConfig tableConfig, Schema
schema) {
+ if (tableConfig.getUpsertMode() == UpsertConfig.Mode.NONE &&
tableConfig.getDedupConfig() == null) {
Review Comment:
Understood. We should also skip the validation when `DedupConfig` is
available, but dedup is not enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
