saurabhd336 commented on code in PR #8708:
URL: https://github.com/apache/pinot/pull/8708#discussion_r887547896
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -538,6 +539,7 @@ private void processStreamEvents(MessageBatch
messagesAndOffsets, long idlePipeS
}
for (GenericRow transformedRow : reusedResult.getTransformedRows()) {
try {
+ // TODO(saurabh): we may have dropped the record due to dedup.
Should we increment indexedMessageCount?
Review Comment:
Ack. I think with the metric added, this is no longer needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
