nizarhejazi commented on code in PR #8872:
URL: https://github.com/apache/pinot/pull/8872#discussion_r899552287
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockBuilder.java:
##########
@@ -289,7 +304,7 @@ public static ColumnarDataBlock
buildFromColumns(List<Object[]> columns, DataSch
}
private static RowDataBlock buildRowBlock(DataBlockBuilder builder) {
- return new RowDataBlock(builder._numRows, builder._dataSchema,
builder._reverseDictionaryMap,
+ return new DataTableImplV4(builder._numRows, builder._dataSchema,
builder._reverseDictionaryMap,
Review Comment:
One issue here is that `getDataBlockVersionType()` is implemented
differently between `RowDataBlock` (returns 1 now) and `DataTableImplV4`
(returns 4). As a result the serialized version returned by `toBytes()` is
different between the two. `DataTableFactory.getDataTable()` looks for version
4 explicitly to build `DataTableImplV4`. Please check this line in
testDataBlockBuilderV4() test:
` BaseDataBlock dataBlock = (BaseDataBlock)
DataTableFactory.getDataTable(rowDataBlock.toBytes());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
