nizarhejazi commented on code in PR #8872:
URL: https://github.com/apache/pinot/pull/8872#discussion_r899553126
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV4.java:
##########
@@ -48,7 +50,26 @@ public DataTableImplV4(int numRows, DataSchema dataSchema,
Map<String, Map<Integ
}
@Override
- protected int getDataBlockVersionType() {
+ public RoaringBitmap getNullRowIds(int colId) {
+ // _fixedSizeData stores two ints per col's null bitmap: offset, and
length.
Review Comment:
This method depends on `_rowSizeInBytes` which is only defined in
`RowDataBlock`. Will move to `RowDataBlock`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
