nizarhejazi commented on code in PR #8872:
URL: https://github.com/apache/pinot/pull/8872#discussion_r899630994
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/RowDataBlock.java:
##########
@@ -48,6 +50,29 @@ public RowDataBlock(ByteBuffer byteBuffer)
computeBlockObjectConstants();
}
+ @Override
+ public RoaringBitmap getNullRowIds(int colId) {
Review Comment:
@Jackie-Jiang I mentioned in my other comment that `BaseDataBlock` has two
implementations: `RowDataBlock` and `ColumnarDataBlock`. Only `RowDataBlock`
has `_rowSizeInBytes` field which we use to calculate position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
