timsants commented on code in PR #8856:
URL: https://github.com/apache/pinot/pull/8856#discussion_r918546748
##########
pinot-controller/src/main/java/org/apache/pinot/controller/tuner/RealTimeAutoIndexTuner.java:
##########
@@ -42,4 +42,10 @@ public TableConfig apply(PinotHelixResourceManager
pinotHelixResourceManager,
initialIndexingConfig.setNoDictionaryColumns(schema.getMetricNames());
return tableConfig;
}
+
+ @Override
+ public TableConfig apply(PinotHelixResourceManager pinotHelixResourceManager,
+ TableConfig tableConfig, Schema schema, Map<String, String>
extraProperties, Map<String, String> httpHeaders) {
+ return apply(pinotHelixResourceManager, tableConfig, schema,
extraProperties);
Review Comment:
Yes its ignored for this case since there are no remote calls being made for
this TableConfigTuner impl. Shall we just name the param `ignored` to make it
clearer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
