walterddr commented on code in PR #8856:
URL: https://github.com/apache/pinot/pull/8856#discussion_r920595325
##########
pinot-common/src/main/java/org/apache/pinot/common/helix/ExtraInstanceConfig.java:
##########
@@ -44,4 +45,31 @@ public String getTlsPort() {
public void setTlsPort(String tlsPort) {
_proxy.getRecord().setSimpleField(PinotInstanceConfigProperty.PINOT_TLS_PORT.toString(),
tlsPort);
}
+
+ /**
+ * Returns an instance URL from the InstanceConfig. Will set the appropriate
protocol and port. Returns null
+ * if the URL cannot be constructed.
+ */
+ public String getComponentUrl() {
Review Comment:
yeah so InstanceConfig host - port is sort of like a "helix" participant
concept. where participate registers with helix of its service host/port.
- for server there's admin, netty and grpc port. the main propose of pinot
server is to talk to pinot-broker so the netty port is usually registered with
helix (as the main service it provides).
- if the idea is to provide a user facing endpoint, then the admin port is
the one user will directly interact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
