walterddr commented on code in PR #8856:
URL: https://github.com/apache/pinot/pull/8856#discussion_r920595867
##########
pinot-common/src/main/java/org/apache/pinot/common/helix/ExtraInstanceConfig.java:
##########
@@ -44,4 +45,31 @@ public String getTlsPort() {
public void setTlsPort(String tlsPort) {
_proxy.getRecord().setSimpleField(PinotInstanceConfigProperty.PINOT_TLS_PORT.toString(),
tlsPort);
}
+
+ /**
+ * Returns an instance URL from the InstanceConfig. Will set the appropriate
protocol and port. Returns null
+ * if the URL cannot be constructed.
+ */
+ public String getComponentUrl() {
Review Comment:
i would suggest renaming it to getComponengRestResourceUrl() if the goal is
to interact with user. and always returns the port for using the REST APIs;
(and obviously the secure port when security is enabled)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
