Jackie-Jiang commented on code in PR #9122:
URL: https://github.com/apache/pinot/pull/9122#discussion_r933554296
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java:
##########
@@ -65,13 +68,24 @@ public static void
setExecutionStatistics(IntermediateResultsBlock resultsBlock,
if (executionStatistics.getNumDocsScanned() > 0) {
numSegmentsMatched++;
}
+ try {
+ if (operator.getIndexSegment() instanceof MutableSegment) {
+ numConsumingSegmentsProcessed += 1;
+ if (executionStatistics.getNumDocsScanned() > 0) {
+ numConsumingSegmentsMatched++;
+ }
+ }
+ } catch (UnsupportedOperationException ignored) { }
Review Comment:
This try catch is redundant
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -670,14 +670,16 @@ private void logBrokerResponse(long requestId, String
query, RequestContext requ
if (_queryLogRateLimiter.tryAcquire() || forceLog(brokerResponse,
totalTimeMs)) {
// Table name might have been changed (with suffix _OFFLINE/_REALTIME
appended)
LOGGER.info("requestId={},table={},timeMs={},docs={}/{},entries={}/{},"
- +
"segments(queried/processed/matched/consuming/unavailable):{}/{}/{}/{}/{},consumingFreshnessTimeMs={},"
+ +
"segments(queried/processed/matched/consumingQueried/consumingMatched/consumingProcessed/unavailable):"
Review Comment:
The ordering is incorrect
```suggestion
+
"segments(queried/processed/matched/consumingQueried/consumingProcessed/consumingMatched/unavailable):"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
