ravishankar15 commented on code in PR #9122:
URL: https://github.com/apache/pinot/pull/9122#discussion_r933578027
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java:
##########
@@ -65,13 +68,24 @@ public static void
setExecutionStatistics(IntermediateResultsBlock resultsBlock,
if (executionStatistics.getNumDocsScanned() > 0) {
numSegmentsMatched++;
}
+ try {
+ if (operator.getIndexSegment() instanceof MutableSegment) {
+ numConsumingSegmentsProcessed += 1;
+ if (executionStatistics.getNumDocsScanned() > 0) {
+ numConsumingSegmentsMatched++;
+ }
+ }
+ } catch (UnsupportedOperationException ignored) { }
Review Comment:
`SelectionCombineOperatorTest.testSelectionLimit0` Should I modify this test
to expect an exception as well ? Also while I was trying the query I was
getting UnsupportedException in the response but the exception has happened
while fetching the metadata. So it gives an impression that the query is not
supported which it is.
Let me know if you still feel we want to change this, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]