Jackie-Jiang commented on code in PR #9122:
URL: https://github.com/apache/pinot/pull/9122#discussion_r933587439
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/CombineOperatorUtils.java:
##########
@@ -65,13 +68,24 @@ public static void
setExecutionStatistics(IntermediateResultsBlock resultsBlock,
if (executionStatistics.getNumDocsScanned() > 0) {
numSegmentsMatched++;
}
+ try {
+ if (operator.getIndexSegment() instanceof MutableSegment) {
+ numConsumingSegmentsProcessed += 1;
+ if (executionStatistics.getNumDocsScanned() > 0) {
+ numConsumingSegmentsMatched++;
+ }
+ }
+ } catch (UnsupportedOperationException ignored) { }
Review Comment:
I see. All the segment top level operator should have this implemented, or
this won't be accurate. Seems it is missing from several operators. We may keep
it like this for now, and let's add a TODO to check all operators and make sure
they have that method properly implemented in a separate PR.
(nit) We usually use 2 lines even when the block is empty
```suggestion
} catch (UnsupportedOperationException ignored) {
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
