siddharthteotia commented on code in PR #9678:
URL: https://github.com/apache/pinot/pull/9678#discussion_r1011041747
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -127,7 +151,15 @@ Map<String, Operation>
computeOperation(SegmentDirectory.Reader segmentReader)
Set<String> newNoDictColumns =
_indexLoadingConfig.getNoDictionaryColumns();
for (String column : existingAllColumns) {
- if (existingNoDictColumns.contains(column) &&
newNoDictColumns.contains(column)) {
+ if (existingNoDictColumns.contains(column) &&
!newNoDictColumns.contains(column)) {
+ if (_schema == null || _indexLoadingConfig.getTableConfig() == null) {
+ // This can only happen in tests.
Review Comment:
why should this happen in tests ? I feel this should be a preconditions
check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
