siddharthteotia commented on code in PR #9678:
URL: https://github.com/apache/pinot/pull/9678#discussion_r1011078687
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -92,10 +112,14 @@ public void updateIndices(SegmentDirectory.Writer
segmentWriter, IndexCreatorPro
Operation operation = entry.getValue();
switch (operation) {
- case CHANGE_RAW_INDEX_COMPRESSION_TYPE:
+ case CHANGE_RAW_INDEX_COMPRESSION_TYPE: {
rewriteRawForwardIndex(column, segmentWriter, indexCreatorProvider);
break;
- // TODO: Add other operations here.
+ }
+ case ENABLE_DICTIONARY: {
+ enableDictionary(column, segmentWriter, indexCreatorProvider);
Review Comment:
(nit) `createDictBasedForwardIndex` or `rewriteDictBasedForwardIndex` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
